Repository navigation
Conversation
style(), styleVariants() and keyframes() accept a debugId and drop it; only createVar, createContainer, layer, fontFace and createTheme use it in the names they generate. Say so in the migration guide, in English and Korean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VE-03(#690, P3): vanilla-extract
style(obj, debugId)가debugId를 받지만 무시합니다.재검증 (main
libs/extractor/src/vanilla_extract.rs)debugId를 이름에 쓰는 API:createVar,createContainer,layer,fontFace,createTheme(StyleCollector::identifier(debug_id, fallback)).style(첫 인자만 읽음),styleVariants,keyframes. 이들의 클래스/keyframes 이름은 Devup UI의 class naming(debug옵션이면 읽기 쉬운 이름)에서 옵니다.결정: 문서화
debugId를 싣는 쪽은 Rust extractor(클래스 이름 생성과style등록 경로)를 바꿔야 해서 이번 범위(TS/문서)에서 제외했습니다.문서만 바꾸므로 changepack은 없습니다.
Test plan
bunx prettier --check(두 mdx)git diff --stat: 각 파일 +2줄, 라인 엔딩 churn 없음Refs #690
🤖 Generated with Claude Code