Repository navigation
fix: don't mark a subject red when only its author is wrong - #339
Merged
Merged
Conversation
When a commit failed only CC017 (an AI tool as its author), the diff showed its subject as a red line, as if the subject had to change. The subject is now red only when the advice is about it. An empty message also no longer shows the commit's author where its subject would be.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Pre-merge checks:
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1034 1038 +4
=========================================
+ Hits 1034 1038 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small mistakes in the new report, both from treating any rule's value as if it were the commit's subject.
-line in the diff, which reads as "this subject has to go". The subject is now red only when the advice is about it (a type, a length, a missing body, a branch name). Otherwise it stays as a grey context line above the advice, as it already does for a fix on another line.Jane Dev <jane@example.com>) where the subject goes in the "All checks" listing, because CC017's value is the author. An AI rule's value now never stands in for the subject, so the row shows only the hash.Before and after
ai_attribution = "forbid", one commit made as Claude with a clean message, one with an empty message:Tests
main.pycoverage stays at 100%.