Repository navigation
fix(messaging): ensure TimeSyncMessage uses unreliable delivery (#4249) - #4253
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
…y-Technologies#4249) - Add NetworkMessageTypes.TimeSync to k_SkipMessageTypes and explicitly map it to NetworkDelivery.UnreliableSequenced in MessageDelivery.UpdateMessageTypes() - Guard TimeSyncMessage.Handle against stale or delayed out-of-order time sync messages - Add unit tests verifying TimeSyncMessage delivery is UnreliableSequenced - Update CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes #4249.
Under packet loss, TimeSyncMessage was sent reliably using NetworkDelivery.ReliableFragmentedSequenced because k_SkipMessageTypes omitted NetworkMessageTypes.TimeSync (despite the code summary explicitly stating it should be skipped due to always using unreliable delivery). Consequently, delayed retransmitted time sync messages caused the client clock to hard-reset backwards when passing HardResetThresholdSec, causing owned NetworkTransforms to stall until the clock caught up.
This PR:
Changelog
Documentation
Testing & QA
Automated tests: