Repository navigation
Conversation
The Coal Plant Predictions sample (people-and-planet-ai/geospatial-classification) no longer runs and isn't maintained in a usable state: - The notebook's setup step installs with `-c constraints.txt`, a file that was removed in 2023, so the notebook stops before any code runs. - task.py uses tf.keras.layers.experimental.preprocessing, which Keras 3 removed, and the serving app can't load the model that the training job writes. - It uses the deprecated COPERNICUS/S2 Earth Engine dataset. - noxfile_config.py tests only Python 3.14, which tensorflow 2.21 doesn't support, so CI never exercises it. - Its labels end in 2021, and many of the labeled plants have since closed or switched to natural gas. Almost all recent changes to the directory are dependency bumps. Rather than keep paying that cost for a sample that can't be run, this removes the code, data, and images, and replaces README.md with a short note that explains the retirement and links to the last version of the code (commit 636f2f5). The people-and-planet-ai index marks the entry as retired and keeps the video link. No region tags or published documentation pages reference this sample.
iennae
added
the
do not merge
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request retires the 'Coal Plant Predictions' (geospatial-classification) sample by deleting its Jupyter notebook, training scripts, serving application, and configuration files. The README files are updated to document the retirement. The feedback suggests a minor grammatical correction in the updated README to use 'doesn't' instead of 'don't' when referring to 'code'.
| * **Training the model**: [TensorFlow] in [Vertex AI] | ||
| * **Getting predictions**: [TensorFlow] in [Cloud Run] | ||
| * The notebook no longer runs: its setup step depends on a file that was removed | ||
| in 2023, and its training and serving code don't work with Keras 3. |
Contributor
There was a problem hiding this comment.
The word "code" is a singular uncountable noun in this context, so "doesn't" should be used instead of "don't".
Suggested change
| in 2023, and its training and serving code don't work with Keras 3. | |
| in 2023, and its training and serving code doesn't work with Keras 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retires the Coal Plant Predictions sample (
people-and-planet-ai/geospatial-classification).The sample no longer runs, so it isn't useful to developers, and keeping it means continuing to update its dependencies:
-c constraints.txt, a file that was removed in 2023, so the notebook stops before any code runs.task.pyusestf.keras.layers.experimental.preprocessing, which Keras 3 removed, and the serving app can't load the model that training writes.COPERNICUS/S2Earth Engine dataset.tensorflow2.21 doesn't support, so the sample isn't exercised.This PR removes the code, data, and images, and replaces
README.mdwith a short note that explains the retirement and links to the last version of the code (636f2f5), so existing links to the directory still resolve. Thepeople-and-planet-aiindex marks the entry as retired and keeps the video link.No region tags or published documentation pages reference this sample. After this merges, #14091 can be closed.
Note
Labeled
do not mergeuntil the retirement is signed off.Checklist
Testing
Compliance & Style
Post-Approval Actions